Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved description for editor.useTabStops setting #206552

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Improved description for editor.useTabStops setting #206552

merged 8 commits into from
Mar 11, 2024

Conversation

BrookMaoDev
Copy link
Contributor

Issue Reference: Should resolve #205298

Previous Description for editor.useTabStops:

Inserting and deleting whitespace follows tab stops.

Proposed New Description:

Inserting and deleting whitespace follows tab stops. Full tab deletion occurs upon removing indentation.

This update aims to offer a more informative description for the editor.useTabStops setting, clarifying its behavior. Feedback and suggestions are welcome before finalizing the pull request.

@BrookMaoDev BrookMaoDev marked this pull request as ready for review February 29, 2024 20:10
@hediet
Copy link
Member

hediet commented Mar 4, 2024

To be honest, I understand neither the old nor the new description.

@BrookMaoDev
Copy link
Contributor Author

Okay, I will try and improve it, thanks for the feedback!

@BrookMaoDev
Copy link
Contributor Author

Hi @hediet, could you kindly review my updated description?

Spaces and tabs are inserted and deleted in alignment with tab stops.

I also considered:

Inserting and deleting whitespace aligns with tab stops.

I replaced "follows" with "aligns with" to improve clarity, as suggested by the author of the issue. Would you like further clarification on tab stops, or do you think the descriptions are clear enough? Thank you for your time!

@hediet hediet enabled auto-merge (squash) March 11, 2024 10:36
@hediet
Copy link
Member

hediet commented Mar 11, 2024

Thank you!

@hediet hediet added this to the March 2024 milestone Mar 11, 2024
@hediet hediet merged commit 989dc33 into microsoft:main Mar 11, 2024
6 checks passed
@BrookMaoDev BrookMaoDev deleted the improvements-for-issue-#205298 branch May 17, 2024 15:08
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description for the setting editor.useTabStops
3 participants