Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log resource telemetry also for side-by-side views on browsers. #208196

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

rehmsen
Copy link
Contributor

@rehmsen rehmsen commented Mar 20, 2024

This telemetry is already logged in non-browser environments, and for the regular text editor (and other editors with a single document), but not yet for editors dealing with multiple documents, like "workbench.editors.diffEditorInput".

It is useful to have this telemetry to check how much e.g. the diff editor is used to open certain file types.

Fixes #208187

This telemetry is already logged in non-browser environments, and for the regular text editor (and other editors with a single document), but not yet for editors dealing with multiple documents, like "workbench.editors.diffEditorInput".

It is useful to have this telemetry to check how much e.g. the diff editor is used to open certain file types.

Fixes microsoft#208187
@Yoyokrazy Yoyokrazy assigned lramos15 and unassigned Yoyokrazy Mar 21, 2024
@lramos15 lramos15 added this to the March 2024 milestone Mar 22, 2024
@lramos15 lramos15 enabled auto-merge (squash) March 22, 2024 17:22
@lramos15 lramos15 merged commit 385ad93 into microsoft:main Mar 22, 2024
5 of 6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Browser, 'editorOpened' telemetry event does not contain any 'resource' descriptor for the diff view
4 participants