-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added http.noProxy setting which is same as NO_PROXY env variable value that is already present currently #211958
Conversation
…ue that is already present currently
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. To make it work for extensions (it currently only reconfigures Electron), you also need to loop the value in to: https://github.com/microsoft/vscode-proxy-agent/blob/91b81109c75632b18fa2340f296ccaff9e9bcefa/src/index.ts#L80
Hi @chrmarti ,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Testing Process
To test the
http.noProxy
setting in Visual Studio Code, you can follow these steps:Open Visual Studio Code: Launch Visual Studio Code on your computer.
Access Settings: Navigate to the settings panel by clicking on "File" > "Preferences" > "Settings" or by using the shortcut
Ctrl + ,
(Cmd + ,
on macOS).Search for
http.noProxy
Setting: In the search bar at the top of the settings panel, typehttp.noProxy
. This will filter the settings to display only thehttp.noProxy
setting.Modify
http.noProxy
Setting (if necessary): If you haven't already set thehttp.noProxy
value, you can add it by clicking on the "Edit in settings.json" link below the setting. Alternatively, you can directly modify thesettings.json
file. Set the value ofhttp.noProxy
to a comma-separated list of domains or IP addresses that you want to exclude from the HTTP proxy routing. For example:Save Settings: After making changes, save the settings.json file.
Test Connectivity: Now, you can test the changes by attempting to access resources that match the exclusions defined in
http.noProxy
. For example, if you've excludedlocalhost
from the proxy routing, try accessing a local server running on your machine.Observe Network Requests: You can also use network debugging tools within Visual Studio Code or external tools like browser developer tools to observe network requests and confirm that the excluded domains or IP addresses are not being routed through the HTTP proxy.
Verify Results: Verify that the excluded resources are accessible without going through the proxy server, confirming that the
http.noProxy
setting is functioning as expected.By following these steps, you can effectively test the
http.noProxy
setting in Visual Studio Code and ensure that it meets your network configuration requirements.