Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive toggle #212218

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

francescov1
Copy link
Contributor

@francescov1 francescov1 commented May 8, 2024

Feature: #88915

This PR adds a recursive toggle fold command. There is already a fold, unfold and toggle fold command, but for recursive fold and unfold there is no recursive toggle fold command.

The command is accessible using shortcut ⌘K ⌘P. I would have preferred using ⌘K ⌘O since its less of a stretch for your fingers, but I felt this would be a bit confusing since there is already a command ⌘K ⌘0 related to folding. Happy to change it if there's any other suggestions.

Will create a PR into the vscode-docs repo as well to include this once reviewed.

@francescov1
Copy link
Contributor Author

@aeschli following up on this PR, myself and a number of engineers at my company are looking forward to this feature

@aeschli aeschli added this to the June 2024 milestone Jun 5, 2024
@aeschli aeschli enabled auto-merge (squash) June 5, 2024 08:52
Copy link
Contributor

@aeschli aeschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌘K ⌘P is already taken

@aeschli
Copy link
Contributor

aeschli commented Jun 5, 2024

I changed the keybinding to Ctrl + K / Ctrl + Shift + L

@aeschli aeschli merged commit 757820a into microsoft:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants