Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. #213067

Merged
merged 3 commits into from
Jun 4, 2024

Commits on Apr 15, 2024

  1. Fix microsoft#182308: Pressing PageUp in the search panel no longer c…

    …auses the layout to change.
    
    Bug (previous behavior):
        1.Press Ctrl+Shift+F to open the search panel.
        2.Enter any text into the search input.
        3.Press PageUp/PageDown.
        4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.
    
    Solution:
    When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.
    
    Testing:
    A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
    franciscacarneiro committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b2ab0ed View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    8367ed0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    23e98af View commit details
    Browse the repository at this point in the history