Fix tsc -p ./src, remove no-default-lib #216760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does CI not check |
|
We do have a lot of checks, hygiene and compilation going on in here: https://dev.azure.com/vscode/VSCode/_build/results?buildId=124881&view=logs&j=c7493abb-a1f4-533f-2d24-71780a69f247&t=82da385d-6a6e-5c36-6c0f-8c375395baef But maybe we miss something. |
|
Running your command returns |
chrmarti
approved these changes
Jun 24, 2024
DonJayamanne
approved these changes
Jun 24, 2024
bricefriha
pushed a commit
to bricefriha/vscode
that referenced
this pull request
Jun 26, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216566 added this file to
tsconfigsuch thattsc -p ./srccompiles it, but it contained ano-default-libdirective. This directive is not supposed to be used except specifically in the case of "I'm writing my own alternativelib.d.tsand need to tell TypeScript to use it instead" (see https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-no-default-libtrue). Having it breaks the standard library definitions. So, remove that.This makes the lib errors go away, but then you hit microsoft/TypeScript#20595 as tsconfig includes DOM which cannot be used with WebWorker. So, remove the file from tsconfig again too.
cc @jrieken @bpasero