Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not show activity bar's focus border on click #217837

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: do not show activity bar's focus border on click #217837

merged 1 commit into from
Jun 26, 2024

Conversation

hecticme
Copy link
Contributor

@hecticme hecticme commented Jun 25, 2024 •
edited
Loading

Related issue

Close #217834

Overview

This will hide the active item indicator of activity bar when using a mouse to click on it. With this change, the flickering border won't happen anymore.

The way to test it is the same as in the related issue:

  • First, to observe the problem, "activityBar.activeBorder" should be transparent. Otherwise, make sure "focusBorder" color is different from "activityBar.activeBorder".
  • Simple click on the explorer icon in the activity bar, the flickering border will not appear this time.

@hecticme hecticme marked this pull request as ready for review June 25, 2024 08:58
279090
279090 approved these changes Jun 25, 2024
View reviewed changes
Copy link

@279090 279090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm start -- --port=8080

@benibenj benibenj assigned benibenj and unassigned daviddossett Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the June 2024 milestone Jun 25, 2024
@benibenj benibenj enabled auto-merge (squash) June 26, 2024 11:00
@benibenj benibenj closed this Jun 26, 2024
auto-merge was automatically disabled June 26, 2024 11:00

Pull request was closed

@benibenj benibenj reopened this Jun 26, 2024
@benibenj benibenj merged commit b4eb545 into microsoft:main Jun 26, 2024
6 checks passed
@hecticme hecticme deleted the fix/actibity-bar-mouse-focus-border branch June 26, 2024 16:00
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
@hecticme @aaronchucarroll
fix: do not show activity bar's focus border on click (microsoft#217837)
23d58b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@benibenj benibenj benibenj approved these changes

@279090 279090 279090 approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
June 2024
Development

Successfully merging this pull request may close these issues.

Should not show focus border of activity bar on mouse click
6 participants
@hecticme @Tyriar @benibenj @279090 @daviddossett @VSCodeTriageBot