Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add npmrc to extensions folder #230214

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

deepak1556
Copy link
Collaborator

#230197 accidentally made changes to extensions/git/package-lock.json that is against the project setting

legacy-peer-deps="true"

This change adds .npmrc to all extension subfolders that need them to avoid such changes if a user were to run npm i under those directories.

I am also looking to catching this in CI, there is no check we have today that can capture this case since we run npm clean install which freezes the lock files.

@deepak1556 deepak1556 added this to the October 2024 milestone Oct 1, 2024
@deepak1556 deepak1556 self-assigned this Oct 1, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) October 1, 2024 09:34
@deepak1556 deepak1556 merged commit 9494a89 into main Oct 1, 2024
7 checks passed
@deepak1556 deepak1556 deleted the robo/fix_package_lock branch October 1, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants