Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional - Open Bot Dialog] The focus goes on the disabled controls and functioning by space/return. #1890

Closed
Kumar2608 opened this issue Oct 1, 2019 · 3 comments
Closed

[Functional - Open Bot Dialog] The focus goes on the disabled controls and functioning by space/return. #1890

Kumar2608 opened this issue Oct 1, 2019 · 3 comments
Assignees
@denscollo
Labels
A11yCT A11yMediumImpact Accessibility Bug Your classic code defect Emulator-MAC Fixed Functional HCL-BotFrameworkEmulator R7 Release 7 - December 10th, 2019 Severity3

Comments

@Kumar2608
Copy link

Kumar2608 commented Oct 1, 2019 •
edited
Loading

Actual Result:
In voiceover mode, the focus lands on the disabled control such as "Connect" button. The voiceover informs that the controls are disabled but if the user accidently press "spacebar" or "return" key the pane gets closed.

Expected Result:
As the controls are disabled, they shouldn't be active or accessed by any key.

Note:
Same issue observed at every disabled controls present throughout the application.

Repro Steps:

  1. Open the Bot Framework V4 Emulator.
  2. Welcome tab screen gets opened.
  3. Navigate to the "Open Bot Dialog" button and activate it.
  4. Open Bot Dialog box gets opened.
  5. Navigate to the dialog box in voiceover mode and select "Connect" disabled button.
  6. Try to activate the button with "Spacebar" or "Enter".
  7. Observe the issue.

User Impact:
If the disabled controls are accessible by keyboard the user might get confused.

Test Environment:
OS: MacOs Version 10.15
Application: Bot Framework V4 Emulator (Version 4.5.2-80829)

Attachment:
Disabled control are functioning.zip
@cwhitten cwhitten assigned denscollo and unassigned tonyanziano Nov 5, 2019
@cwhitten cwhitten added the R7 Release 7 - December 10th, 2019 label Nov 5, 2019
@denscollo denscollo mentioned this issue Nov 21, 2019
Merged
@tonyanziano
Copy link
Contributor

tonyanziano commented Nov 21, 2019 •
edited
Loading

@awalia13 @Kumar2608

Is it recommended to completely hide disabled controls from the screen reader? Or is it better to have them be accessible by the screen reader, but not functional when pressed.

The latter case seems to make more sense to me because, wouldn't you want the non-sighted user to know about all the inputs on the screen? If a disabled buttons becomes enabled after filling out a form, how would the user know it has been enabled if they never knew it was there to begin with?

@tonyanziano tonyanziano added the InfoRequested Used to tag a11y issues that need a response from the a11y team. label Nov 21, 2019
@ShikhaMishra11
Copy link

@tonyanziano As i verified in the latest build of BotFramework Emulator, now the focus didn't lands on the disabled control. I guess it is fixed with #1910

Test Environment:
OS: MacOs Version 10.15
Application: Bot Framework V4 Emulator (version: 4.6.0-92058)

@tonyanziano
Copy link
Contributor

Closing due to above comment.

@ShikhaMishra11 ShikhaMishra11 removed the InfoRequested Used to tag a11y issues that need a response from the a11y team. label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denscollo denscollo

Labels
A11yCT A11yMediumImpact Accessibility Bug Your classic code defect Emulator-MAC Fixed Functional HCL-BotFrameworkEmulator R7 Release 7 - December 10th, 2019 Severity3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @tonyanziano @denscollo @Kumar2608 @ShikhaMishra11