Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Ngrok Debugger Implementation #2032

Merged
merged 30 commits into from
Jan 11, 2020
Merged

WIP: Ngrok Debugger Implementation #2032

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4507aaf
Basic ngrok debugger setup
Dec 13, 2019
902b061
Ui updates completed for ngrok debug console
Dec 17, 2019
0213324
Ngrok redux setup completed. Actions hooked up to ngrokDebugContainer
Dec 20, 2019
1d7c28b
Wrapped up all inputs going into the debuggr ngrok component
Dec 20, 2019
8c969f3
Broadcasting error response
Dec 27, 2019
3d7f8b9
Write stream tests passed
Dec 27, 2019
4b1aadb
Get path initializer
Dec 27, 2019
abe0bf2
Refactoring fn names
Jan 3, 2020
105138e
Reconnect to ngrok functionality completed
Jan 6, 2020
8f4af7b
UI test updated for ngrok container
Jan 6, 2020
95fe0fd
All lock files and fresh installs done
Jan 6, 2020
23b4d99
removed unneeded scss
Jan 6, 2020
ef83075
Renaming classes
Jan 6, 2020
2d9492c
Linter errors and fixes for it across all packages
Jan 6, 2020
ad8a57a
Removed prefixed slash
Jan 6, 2020
7d9f8a9
added rebuild keytar script inside main
Jan 6, 2020
e778e50
Added lock file to ignore
Jan 7, 2020
a9daa47
Revert keytar to old version
Jan 7, 2020
92ed4d1
Updatting postman collection to leverage global variables
Jan 7, 2020
aa20468
Debug container UI tests
Jan 7, 2020
9a34510
Mock Jest Date implementation
Jan 7, 2020
b11dd49
PR review feedback addressed
Jan 9, 2020
3b8f04f
Pre feedback addressed
Jan 9, 2020
88f6642
Made sure all pacjage locks are removed and spacing between cases
Jan 9, 2020
7ce584a
PR review feedback addressed
Jan 9, 2020
49cb853
One more package lock deleted
Jan 9, 2020
f57b6e4
Qna maker package lock removed
Jan 9, 2020
e65aa20
Tests updated after refactor
Jan 9, 2020
c6ff96f
Pr feedback addressed
Jan 10, 2020
6c08711
More copy fixes
Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed prefixed slash
  • Loading branch information
Srinaath Ravichandran committed Jan 6, 2020
commit ad8a57abe9dcd584ba79b976cd44ee87d5e77784
5 changes: 2 additions & 3 deletions packages/app/main/src/ngrok.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const connectToNgrokInstance = async (ngrok: NgrokInstance) => {
try {
const result = await ngrok.connect({
addr: 61914,
path: '/Applications/ngrok',
path: 'Applications/ngrok',
name: 'c87d3e60-266e-11e9-9528-5798e92fee89',
proto: 'http',
});
Expand Down Expand Up @@ -187,9 +187,8 @@ describe('the ngrok ', () => {
} catch (e) {
thrown = e;
}

expect(thrown.toString()).toBe(
`Error: Could not find ngrok executable at path: /${path}. Make sure that the correct path to ngrok is configured in the Emulator app settings. Ngrok is required to receive a token from the Bot Framework token service.`
`Error: Could not find ngrok executable at path: ${path}. Make sure that the correct path to ngrok is configured in the Emulator app settings. Ngrok is required to receive a token from the Bot Framework token service.`
);
});
});
Expand Down