Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go-to-definition on case or default should jump to the containing switch statement if available. #51225

Closed
DanielRosenwasser opened this issue Oct 19, 2022 · 3 comments · Fixed by #51236
Closed

Go-to-definition on case or default should jump to the containing switch statement if available. #51225

DanielRosenwasser opened this issue Oct 19, 2022 · 3 comments · Fixed by #51236
Labels
Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Experience Enhancement Noncontroversial enhancements Good First Issue Well scoped, documented and has the green light Help Wanted You can do this

Comments

@DanielRosenwasser
Copy link
Member 

/*END*/switch (null) {
  /*START*/case null: break;
}
/*END*/switch (null) {
  /*START*/default: break;
}

Those should work.

The following should not have issues.

export /*a*/default {}
export default { /*a*/case }
/*b*/default;
/*c*/case 42;
@DanielRosenwasser DanielRosenwasser added Help Wanted You can do this Good First Issue Well scoped, documented and has the green light Experience Enhancement Noncontroversial enhancements Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. labels Oct 19, 2022
@sviat9440

This comment was marked as outdated.

Sign in to view
@sviat9440 sviat9440 mentioned this issue Oct 20, 2022
Merged
This was referenced Dec 9, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Dec 18, 2022
Merged
@MohitBansal321

This comment was marked as spam.

Sign in to view
@Rohankeshav

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Experience Enhancement Noncontroversial enhancements Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
No milestone
4 participants
@DanielRosenwasser @sviat9440 @Rohankeshav @MohitBansal321