Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated AppLifecycle samples against preview3 and 1.0GA #130

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

andreww-msft
Copy link
Contributor

No description provided.

<TargetPlatformVersion>10.0.19041.0</TargetPlatformVersion>
<TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
<TargetPlatformVersion>10.0.22000.0</TargetPlatformVersion>
<TargetPlatformMinVersion>10.0.22000.0</TargetPlatformMinVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should TPMV be 10.0.17763.0?

@@ -12,7 +12,7 @@
<ProjectGuid>{a55ae73a-73fc-430a-8755-4df2e6f774b0}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>CppWinRtConsoleInstancing</RootNamespace>
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.22137.0</WindowsTargetPlatformVersion>
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.22000.0</WindowsTargetPlatformVersion>
<WindowsTargetPlatformMinVersion>10.0.17134.0</WindowsTargetPlatformMinVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 17763?

@@ -10,6 +10,8 @@
<packageSources>
<clear />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="Internal" value="https://pkgs.dev.azure.com/microsoft/ProjectReunion/_packaging/Project.Reunion.nuget.internal/nuget/v3/index.json" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove before merging

@andreww-msft andreww-msft merged commit f0fc3fe into main Nov 16, 2021
@andreww-msft andreww-msft deleted the user/andreww-msft-GA branch November 16, 2021 19:41
beervoley pushed a commit to paulcam206/WindowsAppSDK-Samples that referenced this pull request Dec 8, 2022
)

* AppLifecycle: updated to preview3

* AppLifecycle: updated to 1.0 GA candidate build 2111.15001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants