Btueffers dynamic dependency bootstrap initialize #187

btueffers · 2022-04-08T19:39:27Z

Description

Updating to use new Bootstrap Initialize API

Target Release

1.1 Preview 2 timeline

Checklist

Samples build and run using the Visual Studio versions listed in the Windows development docs.
Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
Samples set the minimum supported OS version to Windows 10 version 1809.
Samples build clean with no warnings or errors.
[For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
I have commented on my PR /azp run to have the CI build run on my branch. This must be done right before merging to ensure the build is up to date and accurate.

DrusTheAxe · 2022-04-08T20:55:30Z

...Lifecycle/Activation/cs-winforms-unpackaged/CsWinFormsActivation/CsWinFormsActivation.csproj

@@ -2,7 +2,7 @@

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
-    <TargetFramework>net5.0-windows10.0.19041.0</TargetFramework>
+    <TargetFramework>net6.0-windows10.0.19041.0</TargetFramework>


Are samples supposed to use .NET 5 or 6?

Is there a doc of policies and guidelines what samples are supposed to do? E.g. what version of .NET they should use?

DrusTheAxe · 2022-04-08T21:00:17Z

Samples/AppLifecycle/Activation/cs-winforms-unpackaged/CsWinFormsActivation/Program.cs

+            // Initialize Windows App SDK for unpackaged apps.
+            int result;
+
+            Bootstrap.TryInitialize(majorMinorVersion, versionTag, out result);


Replace lines 24-28 with

int result = 0; if (!Bootstrap.TryInitialize(majorMinorVersion, versionTag, minVersion, out result)) { Application.Run...

same applies to all

DrusTheAxe · 2022-04-08T21:03:01Z

Samples/AppLifecycle/Activation/cs-winforms-unpackaged/CsWinFormsActivation/Program.cs

@@ -3,6 +3,7 @@

 using System;
 using System.Windows.Forms;
+using Microsoft.Windows.ApplicationModel.DynamicDependency;

 namespace CsWinFormsActivation
 {


Replace lines 13-14 with

static var majorMinorVersion = global::Microsoft.WindowsAppSDK.Release.MajorMinor; static var versionTag = global::Microsoft.WindowsAppSDK.Release.VersionTag; static var minVersion = new global::Microsoft.Windows.ApplicationModel.DynamicDependency.PackageVersion(Microsoft.WindowsAppSDK.Runtime.Version.UInt64);

same applies to all

Just to confirm @DrusTheAxe, is replacing the types with var intentional in your recommendation?

Yes. It could go either way for majorMinorVersion and versionTag but general rule is objects are better as var when the right side of the = is the type e.g.

Widget x = new Widget();

is better as

var x = new Widget();

since it's unambiguous to the reader what the type of x is.

For majorMinorVersion and versionTag they're constants so for consistency var seemed better, though one could make a case for uint and string.

DrusTheAxe · 2022-04-08T21:07:08Z

Samples/AppLifecycle/Activation/cs-winforms-unpackaged/CsWinFormsActivation/Program.cs

@@ -3,6 +3,7 @@

 using System;
 using System.Windows.Forms;
+using Microsoft.Windows.ApplicationModel.DynamicDependency;


using global::Microsoft...

to avoid ambiguity if implicitUsings are enabled

angelazhangmsft · 2022-04-08T22:45:45Z

@DrusTheAxe should we use <WindowsPackageType>None</WindowsPackageType> in the samples instead of calling the Bootstrap API? Is Bootstrap initialize/shutdown still required if you use that project property?

As documented here: https://docs.microsoft.com/en-us/windows/apps/winui/winui3/create-your-first-winui3-app

btueffers · 2022-04-09T02:19:08Z

/azp run SamplesCI-AppLifecycle

azure-pipelines · 2022-04-09T02:19:12Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

azure-pipelines · 2022-04-09T02:26:35Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

kythant · 2022-04-09T02:30:02Z

/azp run SamplesCI-AppLifecycle

azure-pipelines · 2022-04-09T02:30:07Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

kythant · 2022-04-09T03:02:28Z

/azp run SamplesCI-AppLifecycle

azure-pipelines · 2022-04-09T03:02:37Z

Azure Pipelines successfully started running 1 pipeline(s).

…ps://github.com/microsoft/windowsappsdk-samples into btueffers-DynamicDependency-BootstrapInitialize

btueffers · 2022-04-20T01:40:04Z

/azp run SamplesCI-AppLifecycle

azure-pipelines · 2022-04-20T01:40:13Z

Azure Pipelines successfully started running 1 pipeline(s).

DrusTheAxe · 2022-04-20T16:01:38Z

Samples/AppLifecycle/Activation/cs-console-unpackaged/CsConsoleActivation/Program.cs

-            int result = MddBootstrap.Initialize(majorMinorVersion, versionTag);
-            if (result == 0)
+            int result = 0;
+            if (!Bootstrap.TryInitialize(majorMinorVersion, versionTag, minVersion, out result))


NIT: Can remove versionTag + minVersion and just use the overloaded API to get the default. Not like the actual values are listed here anyway (just symbolic names)

DrusTheAxe · 2022-04-20T16:02:53Z

...AppLifecycle/Activation/cs-console-unpackaged/CsConsoleActivation/CsConsoleActivation.csproj

@@ -2,7 +2,7 @@

  <PropertyGroup>
    <OutputType>Exe</OutputType>
-    <TargetFramework>net5.0-windows10.0.19041.0</TargetFramework>
+    <TargetFramework>net6.0-windows10.0.19041.0</TargetFramework>


We're using .net6 for all samples?
We're using VS2022?

WinAppSDK 1.1 still supports .NET5? Still supports VS2019?

There's a PR out to change it for the C# samples template, but it's not all samples at this point. I was changing a number of C# samples all at once though so I decided to go ahead and tack on the .NET version as well.

DrusTheAxe · 2022-04-20T16:04:09Z

...Lifecycle/Instancing/cs-winforms-unpackaged/CsWinFormsInstancing/CsWinFormsInstancing.csproj

@@ -2,7 +2,7 @@

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
-    <TargetFramework>net5.0-windows10.0.19041.0</TargetFramework>
+    <TargetFramework>net6.0-windows10.0.19041.0</TargetFramework>


19041 == 20H1

Do all samples target that? RS5+19H2 are supported but not a target for samples?

The C# template still targets 19041 so if not all samples then most of them would still be targeting that. We can update it in the template as well though in the same PR that the .NET version is being update in if we want to do that.

btueffers · 2022-04-21T01:33:03Z

/azp run SamplesCI-AppLifecycle

azure-pipelines · 2022-04-21T01:33:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-04-21T01:44:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-04-21T16:46:18Z

Azure Pipelines successfully started running 1 pipeline(s).

* Removing MddBootstrap.cs and use the new Bootstrap.Initialize API * Readding some removed code from program.cs * AppLifecycle Instancing CSConsole unpackaged * AppLifecycle StateNotifications CsConsole Unpackaged State * App Lifecycle Instancing CsWpf unpackaged * App Lifecycle Activation Cs Wpf unpackaged * App Lifecycle StateNotifications Cs WinForms Unpackaged * App Lifecycle Activation Cs console unpackaged * App Lifecycle StateNotifications Cs Wpf unpackaged * App Lifecycle Instancing Cs WinForms unpackaged * implementing some of the PR feedback * updating version variables and if statements * Fixed AppLifecycle CsWpfInstancing * Corrected variable declarations and logic

btueffers added 5 commits April 8, 2022 09:43

Removing MddBootstrap.cs and use the new Bootstrap.Initialize API

5dbd07a

Readding some removed code from program.cs

fc78b0c

AppLifecycle Instancing CSConsole unpackaged

524dc4d

AppLifecycle StateNotifications CsConsole Unpackaged State

dfd2524

App Lifecycle Instancing CsWpf unpackaged

d2e3741

btueffers requested review from DrusTheAxe and angelazhangmsft April 8, 2022 20:53

btueffers added 3 commits April 8, 2022 13:58

App Lifecycle Activation Cs Wpf unpackaged

3a583d9

App Lifecycle StateNotifications Cs WinForms Unpackaged

93b938f

App Lifecycle Activation Cs console unpackaged

ebf3b6c

DrusTheAxe reviewed Apr 8, 2022

View reviewed changes

btueffers added 2 commits April 8, 2022 14:32

App Lifecycle StateNotifications Cs Wpf unpackaged

3e5b669

App Lifecycle Instancing Cs WinForms unpackaged

2967811

btueffers added 2 commits April 8, 2022 16:28

implementing some of the PR feedback

c96a9a0

updating version variables and if statements

e9a757e

btueffers requested a review from andreww-msft April 9, 2022 02:18

Merge branch 'main' into btueffers-DynamicDependency-BootstrapInitialize

349270c

btueffers added 2 commits April 19, 2022 18:39

Fixed AppLifecycle CsWpfInstancing

bccced4

Merge branch 'btueffers-DynamicDependency-BootstrapInitialize' of htt…

f3accab

…ps://github.com/microsoft/windowsappsdk-samples into btueffers-DynamicDependency-BootstrapInitialize

DrusTheAxe reviewed Apr 20, 2022

View reviewed changes

DrusTheAxe approved these changes Apr 20, 2022

View reviewed changes

Corrected variable declarations and logic

3136098

btueffers marked this pull request as ready for review April 22, 2022 16:30

btueffers merged commit 3c59da7 into main Apr 22, 2022

btueffers deleted the btueffers-DynamicDependency-BootstrapInitialize branch April 22, 2022 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Btueffers dynamic dependency bootstrap initialize #187

Btueffers dynamic dependency bootstrap initialize #187

btueffers commented Apr 8, 2022 •

edited

Loading

DrusTheAxe Apr 8, 2022

DrusTheAxe Apr 8, 2022

DrusTheAxe Apr 8, 2022

btueffers Apr 8, 2022

DrusTheAxe Apr 9, 2022

DrusTheAxe Apr 8, 2022

angelazhangmsft commented Apr 8, 2022 •

edited

Loading

btueffers commented Apr 9, 2022 •

edited

Loading

azure-pipelines bot commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

kythant commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

kythant commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

btueffers commented Apr 20, 2022

azure-pipelines bot commented Apr 20, 2022

DrusTheAxe Apr 20, 2022

DrusTheAxe Apr 20, 2022

btueffers Apr 22, 2022

DrusTheAxe Apr 20, 2022

btueffers Apr 22, 2022

btueffers commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

Btueffers dynamic dependency bootstrap initialize #187

Btueffers dynamic dependency bootstrap initialize #187

Conversation

btueffers commented Apr 8, 2022 • edited Loading

Description

Target Release

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angelazhangmsft commented Apr 8, 2022 • edited Loading

btueffers commented Apr 9, 2022 • edited Loading

azure-pipelines bot commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

kythant commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

kythant commented Apr 9, 2022

azure-pipelines bot commented Apr 9, 2022

btueffers commented Apr 20, 2022

azure-pipelines bot commented Apr 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btueffers commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

azure-pipelines bot commented Apr 21, 2022

btueffers commented Apr 8, 2022 •

edited

Loading

angelazhangmsft commented Apr 8, 2022 •

edited

Loading

btueffers commented Apr 9, 2022 •

edited

Loading