Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for WinAppSDK 1.2 #268

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Updates for WinAppSDK 1.2 #268

merged 5 commits into from
Nov 2, 2022

Conversation

bpulliam
Copy link
Collaborator

@bpulliam bpulliam commented Oct 27, 2022

Description

This adds to the work Mano did and ensures that all samples meet the following:

  • Pointing to WinAppSDK 1.2 (currently preview 2, but will be updated to 1.2 stable upon release)
  • Minimum versions:
    NET 6
    CsWinRT 2.0.0
    CppWinRT 2.0.220929.3
    Windows Implementation Library 1.0.220914.1
    Windows SD Build Tools 10.0.22621.755

Note: The following samples have pre-existing issues and still need to be updated:

  • D3D9ExSample
  • DynamicRefreshRateSample
  • DeploymentManagerSample

Target Release

WinAppSDK 1.2 stable.

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

j0shuams and others added 3 commits October 27, 2022 11:20
* Update net5 samples to net6

* unneeded CsWinRT reference
* Fix UpdateVersions.ps1 to accomodate that samples can be on different versions.

* Update build tools version

* Update more samples.
Copy link
Contributor

@pratikone pratikone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bpulliam
Copy link
Collaborator Author

bpulliam commented Nov 2, 2022

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@bpulliam bpulliam merged commit 3451153 into microsoft:main Nov 2, 2022
@bpulliam bpulliam deleted the release/1.2 branch November 2, 2022 16:13
beervoley pushed a commit to paulcam206/WindowsAppSDK-Samples that referenced this pull request Dec 8, 2022
* Net6 update (microsoft#248)

* Update net5 samples to net6

* unneeded CsWinRT reference

* Cherry-pick UpdateVersion and update build tools version (microsoft#251)

* Fix UpdateVersions.ps1 to accomodate that samples can be on different versions.

* Update build tools version

* Update more samples.

* Update CppWinRT, WinAppSDK, BuildTools, wil versions

* change Build Tools from .1 to .755

* fix merge issue and missing buildtools changes

Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com>
Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants