-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for WinAppSDK 1.2 #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update net5 samples to net6 * unneeded CsWinRT reference
* Fix UpdateVersions.ps1 to accomodate that samples can be on different versions. * Update build tools version * Update more samples.
pratikone
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pratikone
approved these changes
Oct 27, 2022
manodasanW
reviewed
Oct 28, 2022
Samples/AppLifecycle/Restart/cpp-console-unpackaged/cpp-console-unpackaged.vcxproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Oct 28, 2022
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
beervoley
pushed a commit
to paulcam206/WindowsAppSDK-Samples
that referenced
this pull request
Dec 8, 2022
* Net6 update (microsoft#248) * Update net5 samples to net6 * unneeded CsWinRT reference * Cherry-pick UpdateVersion and update build tools version (microsoft#251) * Fix UpdateVersions.ps1 to accomodate that samples can be on different versions. * Update build tools version * Update more samples. * Update CppWinRT, WinAppSDK, BuildTools, wil versions * change Build Tools from .1 to .755 * fix merge issue and missing buildtools changes Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com> Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds to the work Mano did and ensures that all samples meet the following:
NET 6
CsWinRT 2.0.0
CppWinRT 2.0.220929.3
Windows Implementation Library 1.0.220914.1
Windows SD Build Tools 10.0.22621.755
Note: The following samples have pre-existing issues and still need to be updated:
Target Release
WinAppSDK 1.2 stable.
Checklist
/azp run SamplesCI-<FeatureName>
to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.