Build Performance #283
Build Performance #283
Conversation
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run SamplesCI-AppLifeCycle, SamplesCI-Composition, SamplesCI-Content, SamplesCI-CustomControls, SamplesCI-DeploymentManager, SamplesCI-Input, SamplesCI-Insights, SamplesCI-Installer |
|
Azure Pipelines successfully started running 6 pipeline(s). |
| </PropertyGroup> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.WindowsAppSDK.1.2.221109.1\build\native\Microsoft.WindowsAppSDK.props" Condition="Exists('$(NugetPackageDirectory)\Microsoft.WindowsAppSDK.1.2.221109.1\build\native\Microsoft.WindowsAppSDK.props')" /> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.Windows.SDK.BuildTools.10.0.22621.755\build\Microsoft.Windows.SDK.BuildTools.props" Condition="Exists('$(NugetPackageDirectory)\Microsoft.Windows.SDK.BuildTools.10.0.22621.755\build\Microsoft.Windows.SDK.BuildTools.props')" /> | ||
| <Import Project="$(NugetPackageDirectory)\Microsoft.Windows.CppWinRT.2.0.221104.6\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(NugetPackageDirectory)\Microsoft.Windows.CppWinRT.2.0.221104.6\build\native\Microsoft.Windows.CppWinRT.props')" /> | ||
| <Import Project="..\..\..\..\Build.Common.Cpp.props" Condition="Exists('..\..\..\..\Build.Common.Cpp.props')"/> | ||
| <PropertyGroup Label="Globals"> |
There was a problem hiding this comment.
if we're trying to keep these samples independently buildable (as they should be), then we should remove all common build logic, source code, etc
There was a problem hiding this comment.
Lolz
- "we should remove all common build logic"
- "we should consolidate common settings" in the next comment below
Agreed with both points, though on the latter the current code is redundant but I'd go a step further. Actually do common repo-wide definitions while still being individually buildable
One way is to make a common Directory.Build.props in the root and every project dir, identical except the project-dir copy starts with IF Exists(..\Directory.Build.props) THEN Import(..\Directory.Build.props) ELSE ...all the content setting properties etc in the root copy... Then future changes can be made to the root copy and a simply Powershell script can walk the tree regenerating all the local copies with that content plus the IF ELSE wrapper.
Other ways to achieve similar net result. Goal is to manually put common things (like PlatformToolset) in a single place and have it affect all, but still work if a developer just grabs 1 project and builds it
| @@ -36,7 +40,7 @@ | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <PlatformToolset>v142</PlatformToolset> | |||
| <PlatformToolset>v143</PlatformToolset> | |||
| <CharacterSet>Unicode</CharacterSet> | |||
There was a problem hiding this comment.
while we're in here, we should consolidate common settings like this to make future updates simpler. and we should make this a default to allow overriding (upgrading)
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="Microsoft.UI.Xaml" version="2.8.0-prerelease.210927001" targetFramework="native" /> | |||
| <package id="Microsoft.Web.WebView2" version="1.0.1018-prerelease" targetFramework="native" /> | |||
| <package id="Microsoft.Web.WebView2" version="1.0.1083-prerelease" targetFramework="native" /> | |||
| </packages> | |||
There was a problem hiding this comment.
Would this repo benefit from the DevCheck -CheckDependencies / MasterSourceOfTruth/master-dependency-definition/verification like we added recently in WinAppSDK?
Will copied DevCheck.* to eng\* to propogate everywhere via Maestro, of urgent need to leverage some functionality and more longer-term. That's currently an older copy as there were changes pending. I've got a change going in RSN to finish that (moving Foundation's (latest) copy to eng\) so it should be available for use in this repo if we want.
Do we want?
|
I completely agree with all comments. I'm going ahead with the merge so we bank this level of improvement. |
Description
Please include a summary of the change and/or which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Target Release
Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.
Checklist
/azp run SamplesCI-<FeatureName>to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.