-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/jecollin/simpleislandapp #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the "to do checklist" is still 'in progress', so perhaps there are already plans to do these:
- please enable arm64 if feasible. Beware that when hooking up with nightly builds, sample apps that support arm64 and those that don't are being hooked up at different spots, i.e., if arm64 is being enabled in a later round, the aggregation repo will need to be changed again. No big deal, just for awareness.
- I recall seeing the potential of adding a packaged favor of this sample app. Therefore, consider putting your current sample app under /Samples/SimpleIslandApp/cpp-win32-unpackaged, so that other favors that you might add in the future can just go right next into a peer folder. Most of other sample apps are structured this way.
/azp run SamplesCI-Islands |
No pipelines are associated with this pull request. |
/azp run SamplesCI-Islands |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SamplesCI-Islands |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This adds a new sample called "Simple Island app". The concept of this sample is that it starts with VS's Win32 desktop app template, and adds what's needed to pull in WinAppSDK and put a single island in that app with Xaml content. It uses WinAppSDK as a Framework Package, and is an "unpackaged" app to stay true to the goal of keeping it as much like a vanilla win32 app as possible.
The best way to understand this change is to go commit by commit. The first commit is the blank Win32 project from the VS template. Then we add nuget packages. Then we make our necessary changes to put Xaml onto the app.
Still TODO:
Target Release
This sample is for use with WinAppSDK 1.4 and later.
Checklist
TODO: STILL IN PROGRESS
/azp run SamplesCI-<FeatureName>
to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.