Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/jecollin/simpleislandapp #307

Merged
merged 17 commits into from
Sep 21, 2023
Merged

User/jecollin/simpleislandapp #307

merged 17 commits into from
Sep 21, 2023

Conversation

JesseCol
Copy link
Collaborator

@JesseCol JesseCol commented Aug 28, 2023

Description

This adds a new sample called "Simple Island app". The concept of this sample is that it starts with VS's Win32 desktop app template, and adds what's needed to pull in WinAppSDK and put a single island in that app with Xaml content. It uses WinAppSDK as a Framework Package, and is an "unpackaged" app to stay true to the goal of keeping it as much like a vanilla win32 app as possible.

The best way to understand this change is to go commit by commit. The first commit is the blank Win32 project from the VS template. Then we add nuget packages. Then we make our necessary changes to put Xaml onto the app.

Still TODO:

  • Add code to make tab navigation work.

Target Release

This sample is for use with WinAppSDK 1.4 and later.

Checklist

TODO: STILL IN PROGRESS

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

Copy link

@codendone codendone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@alexlamtest alexlamtest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the "to do checklist" is still 'in progress', so perhaps there are already plans to do these:

  • please enable arm64 if feasible. Beware that when hooking up with nightly builds, sample apps that support arm64 and those that don't are being hooked up at different spots, i.e., if arm64 is being enabled in a later round, the aggregation repo will need to be changed again. No big deal, just for awareness.
  • I recall seeing the potential of adding a packaged favor of this sample app. Therefore, consider putting your current sample app under /Samples/SimpleIslandApp/cpp-win32-unpackaged, so that other favors that you might add in the future can just go right next into a peer folder. Most of other sample apps are structured this way.

@JesseCol
Copy link
Collaborator Author

/azp run SamplesCI-Islands

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JesseCol
Copy link
Collaborator Author

/azp run SamplesCI-Islands

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JesseCol
Copy link
Collaborator Author

/azp run SamplesCI-Islands

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JesseCol JesseCol merged commit 07678a5 into main Sep 21, 2023
16 checks passed
@JesseCol JesseCol deleted the user/jecollin/simpleislandapp branch September 21, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants