Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Fixes for ARM64 #311

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Additional Fixes for ARM64 #311

merged 6 commits into from
Sep 13, 2023

Conversation

bpulliam
Copy link
Collaborator

Description

A few solutions were missed when adding ARM64 configurations.
Also a few projects had unusual configurations that needed patching.

Target Release

WinAppSDK 1.4

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@evelynwu-msft
Copy link

evelynwu-msft commented Sep 13, 2023

EndGlobalSection

No Release|ARM64? #Closed


Refers to: Samples/AppLifecycle/StateNotifications/cs-wpf-unpackaged/CsWpfState.sln:17 in cfb831c. [](commit_id = cfb831c, deletion_comment = False)

Copy link

@evelynwu-msft evelynwu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link

@evelynwu-msft evelynwu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bpulliam bpulliam merged commit b5917a8 into main Sep 13, 2023
6 checks passed
@bpulliam bpulliam deleted the user/bpulliam/more-arm64 branch September 13, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants