Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting a few larger Sample app build output artifacts into smaller ones to avoid an intermittent download failure #323

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

alexlamtest
Copy link
Collaborator

Description

Downloading larger artifacts to arm64 test VM currently hit Out-Of-Memory exception intermittently. To help avoid this external issue until it gets fixed, splitting a few larger artifacts into smaller ones. In particular:

  • Moved Cs-winui-packaged and Cs-winui-unpackaged under SelfContainedDeployment-cs to new folder SelfContainedDeployment-cs2
  • Moved Cs-winui-packaged under AppLifeCycle-StateNotification-cs to new folder AppLifeCycle-StateNotification-cs2
  • Moved Cs-winui-packaged under AppLifeCycle-Instancing-cs to new folder AppLifeCycle-Instancing-cs2
  • Moved Cs-winui-packaged under AppLifeCycle-Activation-cs to new folder AppLifeCycle-Activation-cs2
  • Moved cpp* folders under Windowing to new folder Windowing-cpp
  • Moved cs* folders under Windowing to new folders Windowing-cs and Windowing-cs1

This PR has no code changes.

Target Release

Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@alexlamtest
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@alexlamtest alexlamtest merged commit ec6b354 into main Feb 1, 2024
2 checks passed
@alexlamtest alexlamtest deleted the user/alexlam/SplitArtifacts-Main-240130 branch February 1, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants