Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prefast C6387 on SimpleIslandApp.cpp #332

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

kythant
Copy link
Contributor

@kythant kythant commented Apr 19, 2024

Prefast results shows

hWnd' could be '0': this does not adhere to the specification for the function 'ShowWindow
hWnd' could be '0': this does not adhere to the specification for the function 'UpdateWindow'. See line 199 for an earlier location where this can occur

The fix was to add a null check and throw if null

@kythant
Copy link
Contributor Author

kythant commented Apr 19, 2024

/azp run Samples-Islands

Copy link

No pipelines are associated with this pull request.

@kythant
Copy link
Contributor Author

kythant commented Apr 19, 2024

/azp run SamplesCI-Islands

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kythant
Copy link
Contributor Author

kythant commented Apr 22, 2024

/azp run SamplesCI-Islands

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kythant kythant merged commit 76a4d19 into main Apr 22, 2024
6 checks passed
@kythant kythant deleted the user/kythant/IslandPrefast branch April 22, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants