Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Ensure chaining of Directory.Build.Props files reaches the new central one for Sample apps #379

Closed
wants to merge 9 commits into from

Conversation

alexlamtest
Copy link
Collaborator

Description

Please include a summary of the change and/or which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Target Release

release/experimental

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

JesseCol and others added 9 commits June 4, 2024 15:10
* Initial checkin

* Add SceneNode Helmet

* Add readme.md

* Organize usings and remove Reunion nuget feed

* Add Lottie
…ental (#360)

* Create Directory.Build.targets

* Update nuget.config

* Update Directory.Build.targets

* Update Directory.Build.targets

* Update WinUIComponentCs.csproj

* Update CsUnpackagedAppNotifications.csproj

* add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat

* Merge additional CoreWebView2 nuget reference fixes (#359)

* Fix up .vcxproj apps for WinUI Custom CWV2SDK support

* Patch all remaining .vcxproj for 1.6 CWV2 work

---------

Co-authored-by: DmitriyKomin <dkomin@microsoft.com>

---------

Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Co-authored-by: Scott Jones <sjones@microsoft.com>
Co-authored-by: DmitriyKomin <dkomin@microsoft.com>
* Port DrawingIsland samples into WASDK 1.6 Exp 2

This ports the user/jeffstall/drawingisland Samples shown at Build 2024 into the release/experimental branch for WASDK 1.6 Exp 2.

* Delete DrawingIsland.cpp

Remove older sample.
@alexlamtest
Copy link
Collaborator Author

I forgot to adjust the target branch before creating this draft PR.

@bpulliam bpulliam deleted the user/alexlam/dbp-exp-20240828 branch August 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants