instructions or gpt_assistant description issue resolve #3102
Conversation
|
Hiii @sonichi @qingyun-wu need some clarification |
| @@ -93,6 +90,7 @@ def __init__( | |||
| instructions, | |||
| openai_assistant_cfg.get("tools", []), | |||
| ) | |||
| instructions = candidate_assistants[0].instructions | |||
There was a problem hiding this comment.
Why is this line needed? Line 174 updates the system message.
I do think that line 173 and 174 can be merged by setting the right system message in line 173 directly, unless
@IANTHEREAL suggests otherwise.
There was a problem hiding this comment.
Sorry for the late reply. At lines 71 and 73, we will remove the model from openai_client_cfg caused by openai assistant api design. Please confirm if this will cause an error with super().__init__. I remember that ConversableAgent._validate_llm_config checks the configuration of the model. If it doesn’t cause an error now, please follow @sonichi suggestion.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Hiii @sonichi @qingyun-wu I made some changes in code please go through it
Related issue number #3101 #3095