Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#544 #545

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix#544 #545

merged 3 commits into from
Aug 29, 2024

Conversation

bmerkle
Copy link
Contributor

@bmerkle bmerkle commented Jul 31, 2024

This is a fix for bug #544

@github-actions GitHub Actions
Copy link

👋 Thanks for contributing @bmerkle! We will review the pull request and get back to you soon.

@github-actions github-actions bot requested a review from koreyspace July 31, 2024 15:31
@bmerkle
Copy link
Contributor Author

bmerkle commented Jul 31, 2024

@microsoft-github-policy-service agree company="SICK-AG"

@github-actions GitHub Actions
Copy link

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
./00-course-setup/README.md 1. https://cla.microsoft.com?WT.mc_id=academic-105485-koreyst
2. https://opensource.microsoft.com/codeofconduct/?WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/cn/README.md 1. https://cla.microsoft.com?WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/ja-jp/README.md 1. https://cla.microsoft.com?WT.mc_id=academic-105485-yoterada
2. https://opensource.microsoft.com/codeofconduct/?WT.mc_id=academic-105485-yoterada
./00-course-setup/translations/ko/README.md 1. http://code.visualstudio.com/?WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/pt-br/README.md 1. http://code.visualstudio.com/?WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/tw/SETUP.md 1. https://code.visualstudio.com/docs/devcontainers/containers?WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/tw/README.md 1. http://code.visualstudio.com/?WT.mc_id=academic-105485-koreyst
2. https://code.visualstudio.com/docs/devcontainers/containers?itemName=ms-python.python&WT.mc_id=academic-105485-koreyst
./00-course-setup/translations/es-mx/README.md 1. http://code.visualstudio.com/?WT.mc_id=academic-105485-koreyst

@bmerkle
Copy link
Contributor Author

bmerkle commented Jul 31, 2024

@koreyspace there seems to be an issue with the URLs in the ./00-course-setup directory
however i have not changed them in this MR so i am a bit puzzled.

I could see 2 problems with the URLs:

  • they redirect according to curl -v (Redirecting to https://opensource.microsoft.com/cla/* Connection #0 to host cla.microsoft.com left intact)
  • then contain a parameter "WT.mc_id=academic-105485-koreyst" which is related to your name ?

@github-actions GitHub Actions
Copy link

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
10-building-low-code-ai-applications/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639-somelezediko74
10-building-low-code-ai-applications/translations/cn/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639-somelezediko74
10-building-low-code-ai-applications/translations/ko/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639-somelezediko74
10-building-low-code-ai-applications/translations/pt-br/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639-somelezediko61
10-building-low-code-ai-applications/translations/tw/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639-somelezediko74
10-building-low-code-ai-applications/translations/ja-jp/README.md
#LinkLine Number
1https://pnp.github.io/powerplatform-prompts/?WT.mc_id=academic-109639yoterada74
02-exploring-and-comparing-different-llms/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom?WT.mc_id=academic-105485-koreyst68
02-exploring-and-comparing-different-llms/translations/cn/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom65
02-exploring-and-comparing-different-llms/translations/ko/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom?WT.mc_id=academic-105485-koreyst64
02-exploring-and-comparing-different-llms/translations/pt-br/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom?WT.mc_id=academic-105485-koreyst68
02-exploring-and-comparing-different-llms/translations/tw/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom?WT.mc_id=academic-105485-koreyst67
02-exploring-and-comparing-different-llms/translations/ja-jp/README.md
#LinkLine Number
1https://sapling.ai/llm/bloom?WT.mc_id=academic-105485-yoterada65
08-building-search-applications/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst68
08-building-search-applications/translations/cn/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst32
2https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst66
08-building-search-applications/translations/ko/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst32
2https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst66
08-building-search-applications/translations/pt-br/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst32
2https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst66
08-building-search-applications/translations/tw/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst34
2https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-koreyst68
08-building-search-applications/translations/ja-jp/README.md
#LinkLine Number
1https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-yoterada32
2https://www.youtube.com/playlist?list=PLlrxD0HtieHi0mwteKBOfEeOYf0LJU4O1?WT.mc_id=academic-105485-yoterada73

panchamnarng30
panchamnarng30 suggested changes Aug 21, 2024
View reviewed changes
Copy link

@panchamnarng30 panchamnarng30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write readable code in the

@koreyspace koreyspace merged commit 72f3576 into microsoft:main Aug 29, 2024
11 of 12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panchamnarng30 panchamnarng30 panchamnarng30 requested changes

@koreyspace koreyspace koreyspace approved these changes

Assignees

@koreyspace koreyspace

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmerkle @koreyspace @panchamnarng30