From c647df1daf286dba52df86acb88acd5b0f93003b Mon Sep 17 00:00:00 2001 From: Ilya Matiach Date: Wed, 14 Feb 2024 16:07:32 -0500 Subject: [PATCH] fix bad whitespace in url format for azure compute instance base url (#2537) --- .../environments/azure_nb_environment.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/rai_core_flask/rai_core_flask/environments/azure_nb_environment.py b/rai_core_flask/rai_core_flask/environments/azure_nb_environment.py index d2d4ecfab4..ef8d8953c1 100644 --- a/rai_core_flask/rai_core_flask/environments/azure_nb_environment.py +++ b/rai_core_flask/rai_core_flask/environments/azure_nb_environment.py @@ -11,6 +11,12 @@ AZURE_NB = "azure_nb" +def get_url_format(is_private_link, instance_name, domain_suffix, port): + if is_private_link: + return f"{instance_name}.{domain_suffix}:{port}" + return f"{instance_name}-{port}.{domain_suffix}" + + class AzureNBEnvironment(BaseEnvironment): """Environment class for Azure notebook environments. @@ -36,14 +42,10 @@ def __init__(self, service): else: instance_name = self.nbvm["instance"] domain_suffix = self.nbvm["domainsuffix"] - if service.is_private_link: - url_format = f"{instance_name}.{domain_suffix}\ - :{service.port}" - else: - url_format = f"{instance_name}-{service.port}\ - .{domain_suffix}" - self.base_url = \ - f"https://{url_format}" + url_format = get_url_format( + service.is_private_link, instance_name, domain_suffix, + service.port) + self.base_url = f"https://{url_format}" self.successfully_detected = True self.nbvm_origins = [ f"https://{instance_name}.{domain_suffix}",