Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y][screen reader] Announce component added after adding a component #1751

Merged
merged 9 commits into from
Sep 28, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 27, 2022

Signed-off-by: Ruby Zhu zhenzhu@microsoft.com

Description

After component added, announce "xxx component added"

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1751 (93f3be7) into main (be17637) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          89       89           
  Lines        5250     5250           
=======================================
  Hits         4636     4636           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 27, 2022 23:39
1 similar comment
u
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
2 similar comments
RubyZ10 and others added 2 commits September 28, 2022 12:49
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
1 similar comment
@RubyZ10 RubyZ10 merged commit 38d3f93 into main Sep 28, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/A11y0926 branch September 28, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants