-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y][screen reader] Announce component added after adding a component #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
September 27, 2022 23:00
Codecov Report
@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 89 89
Lines 5250 5250
=======================================
Hits 4636 4636
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Sep 27, 2022
…nsible-ai-toolbox into zhenzhu/A11y0926
1 similar comment
2 similar comments
imatiach-msft
approved these changes
Sep 28, 2022
gaugup
reviewed
Sep 28, 2022
libs/model-assessment/src/lib/ModelAssessmentDashboard/utils/addTabMessage.ts
Outdated
Show resolved
Hide resolved
gaugup
reviewed
Sep 28, 2022
libs/model-assessment/src/lib/ModelAssessmentDashboard/utils/addTabMessage.ts
Show resolved
Hide resolved
Signed-off-by: Ruby Zhu <zhenzhu@microsoft.com>
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu zhenzhu@microsoft.com
Description
After component added, announce "xxx component added"
Checklist