fix table view for image and text based on discussions for local importances and data analysis #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtances and data analysis
Codecov Report
@@ Coverage Diff @@
## main #1735 +/- ##
===========================================
+ Coverage 78.95% 88.99% +10.04%
===========================================
Files 19 105 +86
Lines 1321 5589 +4268
===========================================
+ Hits 1043 4974 +3931
- Misses 278 615 +337
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuke444
approved these changes
Sep 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on recent discussions, we found that the table view is confusing for users. As a short-term fix, the table view has been duplicated across data analysis and feature importances components. In the longer term future, we are still discussing what the UI design might look like. This PR fixes this, which was already partly done in:
#1726
so that the heading text is more consistent, the data analysis table can't be selected, and the feature importances for the text dashboard can once again be selected (as PR broke the selection mechanism for text dashboard).
Screenshot where data analysis is no longer selectable:
Local importance selection is fixed in text case again (with new header text):
Updated local importances section for tabular data (with new header text):
Checklist