Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs 1.Save and switch doesn't do anything in cohort edit panel 2.Unable to edit cohort filters in certain scenario #2040

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Fix bugs 1.Save and switch doesn't do anything in cohort edit panel 2.Unable to edit cohort filters in certain scenario #2040

merged 4 commits into from
Apr 21, 2023

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Apr 20, 2023 •
edited
Loading

Description

1. Fix Save and switch doesn't do anything in cohort edit panel
Before fix
After save and switch the main dashboard still stays with All cohort
saveB

After fix
After save and switch main dashboard switch to the new cohort
saveA

2. Fix Unable to edit cohort filters in certain scenario
Before fix
editB

After fix
editA

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@RubyZ10
fix bugs
f7a2e9c 
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
@RubyZ10 RubyZ10 marked this pull request as ready for review April 20, 2023 21:15
@RubyZ10 RubyZ10 changed the title Fix bug 1.Save and switch doesn't do anything in cohort edit panel 2.Unable to edit cohort filters in certain scenario Fix bugs 1.Save and switch doesn't do anything in cohort edit panel 2.Unable to edit cohort filters in certain scenario Apr 20, 2023
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/fixCohortBugs/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/fixCohortBugs/dashboard/index.html

@RubyZ10 RubyZ10 enabled auto-merge (squash) April 20, 2023 23:10
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/fixCohortBugs/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/fixCohortBugs/dashboard/index.html

@RubyZ10 RubyZ10 merged commit 6418ce9 into main Apr 21, 2023
@RubyZ10 RubyZ10 deleted the zhenzhu/fixCohortBugs branch April 21, 2023 21:19
@imatiach-msft imatiach-msft mentioned this pull request Apr 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@hawestra hawestra hawestra approved these changes

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft tongyu-microsoft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubyZ10 @imatiach-msft @hawestra