Categorical Exif Metadata support for Vision Dashboard #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2348 +/- ##
===========================================
- Coverage 92.40% 79.06% -13.35%
===========================================
Files 108 26 -82
Lines 5415 2269 -3146
===========================================
- Hits 5004 1794 -3210
- Misses 411 475 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 similar comments
imatiach-msft
approved these changes
Sep 21, 2023
| with Image.open(image_open_pointer) as im: | ||
| if image_mode is not None: | ||
| im = im.convert(image_mode) | ||
| image_array = asarray(im) | ||
| return image_array | ||
|
|
||
|
|
||
| def get_all_exif_feature_names(image_dataset): |
There was a problem hiding this comment.
can you add python tests for these new methods/changes?
…olbox into agemawat/exif
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for categorical image metadata extracted from the exif of the image, propagated on both the Flyout and Model Overview Feature Cohort metrics.
Description
Checklist