Exif Nested Metadata support for Image Dashboards #2542
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
- Coverage 83.96% 78.15% -5.81%
==========================================
Files 95 36 -59
Lines 4951 2619 -2332
==========================================
- Hits 4157 2047 -2110
+ Misses 794 572 -222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if (Array.isArray(expectedNumberOfCohorts)) { | ||
| cy.get(getChartItems(chartIdentifier)) | ||
| .its("length") | ||
| .should("be.gte", expectedNumberOfCohorts[0]) | ||
| .and("be.lte", expectedNumberOfCohorts[1]); | ||
| } else { | ||
| cy.get(getChartItems(chartIdentifier)).should( | ||
| "have.length", | ||
| expectedNumberOfCohorts |
There was a problem hiding this comment.
I think these come from a settings file for each dataset (singleFeatureCohorts or multiFeatureCohorts). I think it might be better to just set these to the correct values for the vision notebooks or only do this type of very loose check for vision notebooks only, since we still want to validate this is consistent for tabular and text notebooks.
There was a problem hiding this comment.
@imatiach-msft these tests are unfortunately so flaky that different python versions were showing different values and hence failing at different steps. For diff versions, this gate (Exif Nested Metadata support for Image Dashboards · microsoft/responsible-ai-toolbox@34f2f52 (github.com) has failed differently across all 3 notebooks.
This pull request includes changes to the
responsibleai_visionpackage, specifically to thefeature_extractors.pyandimage_reader.pyfiles. The changes aim to improve the extraction and processing of image metadata. The most important changes include the addition ofExifTagsandIFDRationalfrom thePILlibrary, the creation of a new functionprocess_datato handle different data types, and the modification of theappend_exif_featuresandget_all_exif_feature_namesfunctions to handle nested tags in the Exif data.Improvements to image metadata extraction and processing:
responsibleai_vision/responsibleai_vision/utils/feature_extractors.py: ImportedExifTagsandIFDRationalfrom thePILlibrary to handle additional metadata types. Created a new functionprocess_datato handle different data types in the Exif data. Modified theappend_exif_featuresfunction to handle nested tags in the Exif data. [1] [2]responsibleai_vision/responsibleai_vision/utils/image_reader.py: ImportedExifTagsfrom thePILlibrary and created a dictionaryIFD_CODE_LOOKUPto map IFD block tags. Modified theget_all_exif_feature_namesfunction to handle nested tags in the Exif data. [1] [2] [3]Description
Ask from 2 customers to expand exif metadata support by including nested types.
Checklist