Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Exif Metadata support + Gate fixes for py 3.7 and keras version #2545

Merged
merged 25 commits into from
Apr 2, 2024

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Mar 10, 2024

Adds nested metadata support, simultaneous ask from 2 customers. Also fixed gates by removing py 3.7 and pegging keras version as 3.0 may not support transformers due to breaking changes, resulting in the need of pegging keras to version 2 and having backwards-compatible tensorflow/keras.

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (e2c7dd0) to head (5f2fe62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   84.00%   78.12%   -5.89%     
==========================================
  Files          95       36      -59     
  Lines        4958     2619    -2339     
==========================================
- Hits         4165     2046    -2119     
+ Misses        793      573     -220     
Flag Coverage Δ
unittests 78.12% <ø> (-5.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Advitya17 Advitya17 marked this pull request as ready for review March 26, 2024 17:33
@Advitya17 Advitya17 changed the title Exif testing Nested Exif Metadata support Mar 26, 2024
@Advitya17 Advitya17 changed the title Nested Exif Metadata support Nested Exif Metadata support + Gate fixes for py 3.7 and keras version Mar 26, 2024
@Advitya17 Advitya17 merged commit 76e0de4 into main Apr 2, 2024
93 of 94 checks passed
@Advitya17 Advitya17 deleted the agemawat/exif_tests branch April 2, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants