fix erroranalysis test failures due to new shap release having inconsistent dimensions for single valued target #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
===========================================
+ Coverage 80.96% 92.12% +11.16%
===========================================
Files 75 108 +33
Lines 3472 5436 +1964
===========================================
+ Hits 2811 5008 +2197
+ Misses 661 428 -233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gaugup
approved these changes
Apr 5, 2024
…istent dimensions for single valued target
bf4420a
to
9b789ad
Compare
Advitya17
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix erroranalysis test failures due to new shap release having inconsistent dimensions for single valued target
Erroranalysis tests started failing which seemed to be caused by the new shap 0.45.0 release
Example exception:
The most generic fix is to manipulate the shape in case we are running for classification scenario and get a two-dimensional shap values array result to be three-dimensional.
Also pinning scikit-learn, see: py-why/EconML#854
to get greenbuild in CD.yml so we can have all green builds again
Checklist