-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade nx to 12.10.1 #2561
Merged
Merged
upgrade nx to 12.10.1 #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd17b43
to
c237fe2
Compare
aa86d03
to
c0919ea
Compare
1 similar comment
cdfe9c5
to
bb80446
Compare
2 similar comments
bb80446
to
a9e459f
Compare
a9e459f
to
b38aa1c
Compare
b38aa1c
to
8a68c00
Compare
8a68c00
to
cc0f0c0
Compare
cc0f0c0
to
a25c7a1
Compare
a25c7a1
to
5896b4f
Compare
5896b4f
to
26a36ea
Compare
RubyZ10
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently node-gyp errors started appearing on macos builds:
Based on stackoverflow issue here:
https://stackoverflow.com/questions/74715990/node-gyp-err-invalid-mode-ru-while-trying-to-load-binding-gyp
It seems the recommendation is to upgrade node-gyp to version 8 or above. However, we have a very old version of nx which depends on this old version of node-gyp. Hence, sending this PR to upgrade nx to 12.x latest version, although even this major version is very old - it is recommended to upgrade nx in stages:
https://nx.dev/recipes/tips-n-tricks/advanced-update#one-major-version-at-a-time-small-steps
This means there may be a series of PRs sent out to upgrade nx for each major version. Attempting to upgrade to the very latest is currently throwing many errors.
Checklist