Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failures due to missing fridge datasets #2573

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Jul 1, 2024

Description

Fix build failures due to missing datasets from deleted blob storage account https://cvbp-secondary.z19.web.core.windows.net/ - I've moved these to our OSS blob storage account https://publictestdatasets.blob.core.windows.net/
Specifically this is for the files fridgeObjects.zip and multilabelFridgeObjects.zip.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (519037c) to head (33fa8eb).

❗ There is a different number of reports uploaded between BASE (519037c) and HEAD (33fa8eb). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (519037c) HEAD (33fa8eb)
unittests 5 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2573       +/-   ##
===========================================
- Coverage   89.38%   78.43%   -10.96%     
===========================================
  Files         106       28       -78     
  Lines        6738     2597     -4141     
===========================================
- Hits         6023     2037     -3986     
+ Misses        715      560      -155     
Flag Coverage Δ
unittests 78.43% <ø> (-10.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft merged commit 42a6d27 into main Jul 1, 2024
92 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-builds-7-1 branch July 1, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants