Skip to content

Latest commit

 

History

History
56 lines (43 loc) · 3.35 KB

GraphClientFactory.md

File metadata and controls

56 lines (43 loc) · 3.35 KB
Raw

Graph Client Factory

Objectives

Provide a class that can be used to create an instances of platform native HTTP client library that are pre-configured for making requests to Graph APIs.

There are two primary usage scenarios for the client factory. Developers who wish to make HTTP requests using the native HTTP library can use the factory to create an instance of the native library that is preconfigured to access the Graph API. The second scenario is where the service library client uses the factory for creating its native HTTP client library internally.

Requirements

  • Enable developer to create a native HTTP client instance that is configured with a pipeline of middleware for Graph requests
  • Allow developer to provide a custom pipeline that future create requests will respect
  • Configure default HTTP handling behavior of native library
    • Define default request timeout (100 secs)
    • If a platform supports connection timeouts, then allow configuration of that. (default 30 secs)
    • Override the default base address for requests
  • Configure default request headers
    • Set the SdkVersion header with the appropriate moniker based on the following structure graph-{lang}-{version}.
  • Enable the developer to select a supported sovereign cloud using an enumerated list. Selecting the sovereign cloud should ensure that the AuthenticationProvider uses the appropriate Authentication Endpoint.
  • Enable a developer to configure a HTTP proxy that will be used for outgoing requests.
  • Enable a developer to provide custom hosts.
    • CustomHosts option should be set on client creation.
    • CustomHosts option should be made available in the Context so that it is available to the middleware during request processing.
    • These hostnames are different from the Graph service endpoints on the national clouds.
    • Certain workloads error out when an unexpected header is present in the request. The middlewares should check:
      • If the request URL is a Graph service endpoint or a custom host provided by the developer, then append request headers or modify the request content.
      • Else the middleware should delete request headers added by that middleware.
    • Example of an workload error - LargeFileUploadTask upload to OneDrive caused CORS error due SDKVersion telemetry header
    • Provide capabilities to modify or update the CustomHosts option after the client creation.

Performance Considerations

  • If available on the platform, enable gzip compression of requests and responses.

Future Implementation

  • Enable developers to set CustomHosts. The progress can be tracked as follows:
| SDK         | Implementation Status|
|-------------|----------------------|
| C#          | -                    |
| JAVA        | -                    |
| PHP         | -                    |
| JavaScript  | In Progress          |

Security Considerations

  • If available on the platform, configure for TLS 1.2

Authorization tokens MUST not be added to the default request headers.

Open Issues

  • Should we define a response stream read timeout?
  • Can the factory detect from the environment which is the appropriate sovereign cloud?
  • Should SdkVersion be set as a default header here in the GraphClientFactory, or should it be put assigned by the TelemetryHandler? Or both?