Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allows registration of page iterator headers #309

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: allows registration of page iterator headers #309

merged 1 commit into from
Jul 15, 2024

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jul 12, 2024

Overview

Fixes #300

Allows registration of errors handler for PageIterator

Demo

	errorMapping := abstractions.ErrorMappings{
		"4XX": internal.CreateSampleErrorFromDiscriminatorValue,
		"5XX": internal.CreateSampleErrorFromDiscriminatorValue,
	}

	err := RegisterError(PageIteratorErrorRegistryKey, errorMapping)

Adding this line when using a page iterator should allow page iterator errors to be mapped

Testing

  • Added unit tests

@rkodev rkodev requested a review from a team as a code owner July 12, 2024 09:54
@rkodev rkodev force-pushed the feat/error-mapping-page-iterator branch from bf757e6 to 725a426 Compare July 12, 2024 11:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rkodev rkodev merged commit d4b0806 into main Jul 15, 2024
8 checks passed
@rkodev rkodev deleted the feat/error-mapping-page-iterator branch July 15, 2024 06:36
@release-please release-please bot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to pass error handler to PageIterator?
3 participants
@rkodev @andrueastman @baywet