Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Ensure support for Python 3.12/3.8/3.7 #962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jamim
Copy link

@Jamim Jamim commented Jan 23, 2024

👋🏻 Hello @mingrammer,

First of all, thank you for this great project! 🙇🏼

The README claims that Python 3.7 or higher is required, so I believe it would be nice to ensure that all 3.7+ versions are actually supported by enabling testing against them on CI.

These changes also:

  • add coverage reporting
  • disable the fail-fast mode for tests
  • make CI use pipx to install poetry
  • make CI use pytest to run tests
  • force colors on CI
  • bump actions/checkout to v4
  • bump actions/setup-python to v5

You can review a test run here 👀

Best regards!

The README claims that Python 3.7 or higher is required,
so I believe it would be nice to ensure that all 3.7+
versions are actually supported by enabling testing
against them on CI.

These changes also:
  - add coverage reporting
  - disable the fail-fast mode for tests
  - make CI use pipx to install poetry
  - make CI use pytest to run tests
  - force colors on CI
  - bump actions/checkout to v4
  - bump actions/setup-python to v5
@Jamim
Copy link
Author

Jamim commented Apr 20, 2024

Hello @mingrammer,

Would you mind reviewing this PR?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant