/botio test

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/972d08d84ab520f/output.txt

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e798e11b530f9d1/output.txt

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/972d08d84ab520f/output.txt

Total script time: 30.62 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 336
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/972d08d84ab520f/reftest-analyzer.html#web=eq.log

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/e798e11b530f9d1/output.txt

Total script time: 45.59 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: Passed

I don't know what to think about this patch.
I agree with what you said and in the meantime this pretty recent feature, probably not that used in the wild (afaik Google docs use it too), helped to find some bugs .
That said pdf.js is not supposed to be a QA tool... ;)
@timvandermeij, wdyt ?

I don't know what to think about this patch.

Understood; I was mainly wanting to get rid of the separate isChrome option since having that present in the code even in the Firefox PDF Viewer just feels wrong (on principle) to me.

I agree with what you said and in the meantime this pretty recent feature, probably not that used in the wild (afaik Google docs use it too), helped to find some bugs .

Could we perhaps instead consider simply removing the isChrome option, and do nothing else, since the new isImageDecoderSupported API-option will allow affected users a way to "recover" on their own?

I have been thinking about this and tend to agree with the direction of this patch. While it's good this caused bugs in Chrome to be found and reported, it shows that the Chrome implementation might need more time to settle before we enable it for a broader audience, and Firefox is our primary development target. If we enable it now it might also cause more bugs to be reported to PDF.js even though they are Chrome browser bugs.

I would propose that we at least try to remove the isChrome API option since to me that also doesn't feel ideal from an API perspective, but I'm also not opposed to disabling ImageDecoder completely in Chrome for some time. That said, if we do that we should have a tracking issue to track enabling it again later on once the bugfixes have reached the Chrome versions we support.

Thank you!

/botio makeref

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/296ea5bb2222280/output.txt

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/5fd77ac015c9754/output.txt

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/296ea5bb2222280/output.txt

Total script time: 20.52 mins

• Make references: Passed
• Check references: Passed

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5fd77ac015c9754/output.txt

Total script time: 25.81 mins

• Make references: Passed
• Check references: Passed