Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing of more Pushover API parameters. #570

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

jlrgraham
Copy link
Contributor

Allow users to specify more of the parameters allowed by the Pushover API. In particular, add support for the embedded URL and HTML formatting options.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @jlrgraham,

thanks a stack for your contribution. I think it will be good to go and I am looking forward to cut another release after merging.

On the feedback side, I spotted a minor typo where I am humbly asking you for correction.

With kind regards,
Andreas.

HANDBOOK.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #570 (6071c1e) into main (3577e62) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   29.19%   29.25%   +0.05%     
==========================================
  Files          82       82              
  Lines        3665     3668       +3     
  Branches      427      429       +2     
==========================================
+ Hits         1070     1073       +3     
  Misses       2546     2546              
  Partials       49       49              
Flag Coverage Δ
unittests 29.25% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqttwarn/services/pushover.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amotl
Copy link
Member

amotl commented Aug 21, 2022

Dear Justin,

before merging, I've just added a corresponding test case to cover the added code. Thank you again.

With kind regards,
Andreas.

@amotl amotl merged commit bfd177b into mqtt-tools:main Aug 21, 2022
@jlrgraham
Copy link
Contributor Author

@amotl, fantastic, many thanks. I'll try to make sure that I get appropriate tests and coverage for future submissions. Best, -Justin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants