Improve SMTP service plugin #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 28.80% 30.02% +1.21%
==========================================
Files 83 83
Lines 3714 3717 +3
==========================================
+ Hits 1070 1116 +46
+ Misses 2644 2601 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
134399c
to
3ad9c2f
Compare
Beforehand, configuring `htmlmsg = False`, as advertised in the documentation, would not work.
3ad9c2f
to
3b0bf1d
Compare
3b0bf1d
to
1f147a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
while adding software tests to the SMTP service plugin with a5b73bf, I discovered a bug where the
htmlmsg=Falseparameter was misinterpreted and not honored, now fixed with f9ce799.Along the lines, I implemented the suggestion from #573 (comment) with 134399c, in order to support a minimal configuration w/o TLS and AUTH, suitable for testing purposes.
With kind regards,
Andreas.