[WIP] Bicep Templates for ACR, KeyVault, AppGW, and AKS #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made root ca certificate optional
|
@teilmeier -- thanks for jump starting this effort with your examples that we were able to reference. We've completed the main file migration in #302. The next phase is modularizing the bicep files here if we feel there is value in that. I'll keep your PR open here, as you've taken the modular approach, but we'd of course like for it to be based on the new bicep file in the repo. Alternatively, if you'd like to close this PR and address it based on the new bicep, that would be fine too. |
|
Going to leave the modular approach to the AKS Baseline automation repo. (recently referenced in #348) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed source branch of Bicep-related changes. Successor of PR #285