Fix Azure Bastion Subnet to be /26 (instead of /27) #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallihan
approved these changes
Oct 7, 2022
networking/topology.md
Outdated
| | Azure Application Gateway Subnet | - | [251] | - | - | - | 100 | 100 | 0 | 0 | 5 | 0 | 256 | 256 | 24 | 10.240.5.0/24 | 10.240.5.0 | 10.240.5.255 | | ||
| | Gateway Subnet (GatewaySubnet) | - | [27<sup>1</sup>] | - | - | - | 100 | 100 | 0 | 0 | 5 | 0 | 32 | 32 | 27 | 10.200.0.64/27 | 10.200.0.64 | 10.200.0.95 | | ||
| | Azure Firewall Subnet (AzureFirewallSubnet) | - | [59] | - | - | - | 100 | 100 | 0 | 0 | 5 | 0 | 64 | 64 | 26 | 10.200.0.0/26 | 10.200.0.0 | 10.200.0.63 | | ||
| | Azure Bastion Subnet (AzureBastionSubnet) | - | [50<sup>2</sup>] | - | - | - | 100 | 100 | 0 | 0 | 5 | 0 | 64 | 64 | 26 | 10.200.0.128/26 | 10.200.0.128 | 10.200.0.191 | |
There was a problem hiding this comment.
The superscript here seems to indicate that there is more information below, but # 2 in Additional Considerations is talking about a different subnet. Not new for this PR, but maybe we can clean that up?
There was a problem hiding this comment.
The superscript link works, it's literally the whole text, when clicked, goes to that data source, but I see what you mean how it could be confused with the numbered list below. Let me fix that! Good idea.
There was a problem hiding this comment.
Double fix, removed the (now) unnecessary superscript -- they were used as differentiators before, and also converted the numbered list into a bullet list in eb674cb
|
Thanks for the review, @hallihan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #342
When this reference implementation was created,
/27was the correct size for Azure Bastion. The latest recommendation is/26-- luckily enough room was left :)AzureBastionSubnetsubnet size, and the related IP table