feat (cluster): [AKS v1.23] bump aks, kured versions and some minors #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckittel
approved these changes
May 3, 2022
There was a problem hiding this comment.
LGTM, thanks!
Just ONE change to make, with the comments. But after you make those changes, you can merge (see followup review). If you want, feel free to copy & paste the description of the role from docs OR you can try to describe it and how it's used in the RI -- either way is fine.
ckittel
requested changes
May 3, 2022
ckittel
reviewed
May 4, 2022
…ions Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #527157
WHY?
aks baseline should remain up to the latest aks version being released.
WHAT Changed?
1.231.9.2existingresourcesreferencefunction usage in favor of using the actual resourceeastus2location to acr and cluster-stamp being a friendly reminder for those who need to deploy to another region without issues.HOW to Test?
you should be able to clone and follow the instructions to provision a new AKS cluster in version
1.23. Cluster looks healthy and you can execute the e2e validation without issues.