-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Policy Refresh #317
Merged
Merged
Azure Policy Refresh #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferantivero
reviewed
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t nicely done @ckittel, a few comments below to be discussed.
ferantivero
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t great additions @ckittel LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshing our Azure Policy assignments. This PR will not address adding custom in-cluster policies.
Changes:
tenantResourceId()
functionflux-system
as it's coming from an extension in moreexcludedNamespaces
on policy assignmentsaudit
->Audit
anddeny
->Deny
to align with the defaults better.take()
is applied to all policy names to prevent a long RG name breaking the assignment nameK8sAzureContainerAllowedImages
.
in the allow listazurearcfork8s.azurecr.io/azurearcflux/images/stable/.+$
as those flux images are now sourced from MCR.K8sAzureContainerLimits
cluster-baseline-settings
K8sAzureReadOnlyRootFilesystem
Audit
toDeny
K8sAzureHostFilesystem
(Deny
)K8sAzureExternalIPs
(Deny
)K8sAzureBlockEndpointEditDefaultRole
(Audit
)Audit
)Unrelated changes bundled in this PR:
dependsOn: []