-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (cluster): [day2-ops] node update configuration #403
Conversation
094ae37
to
2218f2e
Compare
Some explanation: I could not get it to deploy as-is and had to make those two changes in cluster-stamp.bicep Apparently there's a known bug with the configuration of "SecurityPatch & node-image" so we will need to go with "NodeImage & node-image" |
Here's some context on the bug: "Currently, when you set the cluster auto-upgrade channel to node-image, it also automatically sets the node OS auto-upgrade channel to NodeImage. You can't change node OS auto-upgrade channel value if your cluster auto-upgrade channel is node-image. In order to set the node OS auto-upgrade channel value, check the cluster auto-upgrade channel value isn't node-image." I know a handful of other changes were made to support the preview feature SecurityPatch but those may not be necessary now. |
79940cb
to
57b25b1
Compare
@ferantivero Looking good! Can you add some guidance / an example of a maintenance window for the updates? Thanks For reference: |
f2f0a97
to
5a4b3d5
Compare
sure thing @skabou, we added both k8s and os level maint config windows. done | from 1c82e86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some text suggestions
really appreciate all contribs @skabou, accepted them all. |
@ferantivero Really appreciate your work on this! |
Co-authored-by: Jason Bouska <82831332+skabou@users.noreply.github.com>
Co-authored-by: Jason Bouska <82831332+skabou@users.noreply.github.com>
…de OS Level automatically" This reverts commit 2218f2e. this is based on a Node channel known bug: Currently, when you set the cluster auto-upgrade channel to node-image, it also automatically sets the node OS auto-upgrade channel to NodeImage. You can't change node OS auto-upgrade channel value if your cluster auto-upgrade channel is node-image.
Co-authored-by: Jason Bouska <82831332+skabou@users.noreply.github.com>
9754715
to
e99adff
Compare
👍 |
Co-authored-by: Jason Bouska <82831332+skabou@users.noreply.github.com>
🎉 |
securityNodeImage automatic upgradesTested end to end:
![image](./?url=aHR0cHM6Ly9wcml2YXRlLXVzZXItaW1hZ2VzLmdpdGh1YnVzZXJjb250ZW50LmNvbS8xNTg0ODcvMzE1MzM0NTIzLTBhNTU2NGFiLWQzYzMtNDUzZS05YjgyLTc5ZjE1MjM2MTc0NS5wbmc/and0PWV5SmhiR2NpT2lKSVV6STFOaUlzSW5SNWNDSTZJa3BYVkNKOS5leUpwYzNNaU9pSm5hWFJvZFdJdVkyOXRJaXdpWVhWa0lqb2ljbUYzTG1kcGRHaDFZblZ6WlhKamIyNTBaVzUwTG1OdmJTSXNJbXRsZVNJNkltdGxlVFVpTENKbGVIQWlPakUzTWpRd09UTTBPVFVzSW01aVppSTZNVGN5TkRBNU16RTVOU3dpY0dGMGFDSTZJaTh4TlRnME9EY3ZNekUxTXpNME5USXpMVEJoTlRVMk5HRmlMV1F6WXpNdE5EVXpaUzA1WWpneUxUYzVaakUxTWpNMk1UYzBOUzV3Ym1jX1dDMUJiWG90UVd4bmIzSnBkR2h0UFVGWFV6UXRTRTFCUXkxVFNFRXlOVFltV0MxQmJYb3RRM0psWkdWdWRHbGhiRDFCUzBsQlZrTlBSRmxNVTBFMU0xQlJTelJhUVNVeVJqSXdNalF3T0RFNUpUSkdkWE10WldGemRDMHhKVEpHY3pNbE1rWmhkM00wWDNKbGNYVmxjM1FtV0MxQmJYb3RSR0YwWlQweU1ESTBNRGd4T1ZReE9EUTJNelZhSmxndFFXMTZMVVY0Y0dseVpYTTlNekF3SmxndFFXMTZMVk5wWjI1aGRIVnlaVDAzTkdFME1HRmxZemxqWm1Zek5tTXpPRFU1WlRCak9XWmhOakk1WTJWbU9UVXdOekU1TWpabE1tRTVOREJpTVdNMVkyVmtZbUZsWkRJNE5EWmlObVkxSmxndFFXMTZMVk5wWjI1bFpFaGxZV1JsY25NOWFHOXpkQ1poWTNSdmNsOXBaRDB3Sm10bGVWOXBaRDB3Sm5KbGNHOWZhV1E5TUNKOS5hVndUOXZzVFhneUxmM2hIR2FIc1ZIOERQamo5VWdNbUJvNmhHYUlqblJV&__proxy_form=0)
# kured is no longer installed. kubectl get all -n cluster-baseline-settings