Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align resources to resource group location #404

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Align resources to resource group location #404

merged 3 commits into from
Mar 7, 2024

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented Mar 6, 2024 •
edited
Loading

  • By default, use resource group location to drive the location of resources, based on reliability recommendations from resource provider teams.
  • This change required breaking out the hubs and spokes into resource-group-per-region aligned hubs (resource group name changes to include region)
  • Had to remove the region restrictions since you cannot mix defaults with allow lists

Unrelated changes:

  • Updated oldest supported version of kubectl (must be within 1 of the cluster version)
  • Minor typos fixed

Tested end to end:
image

image

Work Item: https://dev.azure.com/msft-skilling/Content/_workitems/edit/217262

@ckittel ckittel marked this pull request as ready for review March 6, 2024 19:23
@ckittel ckittel requested a review from skabou March 6, 2024 19:24
skabou
skabou reviewed Mar 7, 2024
View reviewed changes
04-networking.md Outdated Show resolved Hide resolved
skabou
skabou reviewed Mar 7, 2024
View reviewed changes
05-bootstrap-prep.md Outdated Show resolved Hide resolved
skabou
skabou approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Very thorough! Just those couple editing nits

@ckittel @skabou
Apply suggestions from code review
db3a969 
Co-authored-by: Jason Bouska <82831332+skabou@users.noreply.github.com>
@ckittel
Copy link
Member Author

ckittel commented Mar 7, 2024

Thanks for the improvements and the review! Merging now and closing out the task.

@ckittel ckittel merged commit 51cd9d0 into main Mar 7, 2024
1 check passed
@ckittel ckittel deleted the region-location branch March 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabou skabou skabou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckittel @skabou