Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch (security): [deployment] add secure decorator to x509 private keys #407

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ferantivero
Copy link
Contributor

  • bugfix: decorate private keys with secure string
  • change cert naming convention in bicep

Tested end to end:
image

@ferantivero ferantivero requested a review from skabou March 21, 2024 18:30
@@ -15,7 +15,8 @@ param a0008NamespaceReaderMicrosoftEntraGroupObjectId string
@description('Your AKS control plane Cluster API authentication tenant')
param k8sControlPlaneAuthorizationTenantId string

@description('The certificate data for app gateway TLS termination. It is base64')
@description('The PFX certificate for app gateway TLS termination. It is base64')
@secure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@ferantivero ferantivero merged commit 5d8753d into main Mar 22, 2024
1 check passed
@ferantivero ferantivero deleted the patch/213254_secure-private-keys-params branch March 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants