Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for padding bytes / trailer at end of CF PDU #361

Closed
3 tasks done
jphickey opened this issue Jan 31, 2023 · 0 comments · Fixed by #362
Closed
3 tasks done

Add option for padding bytes / trailer at end of CF PDU #361

jphickey opened this issue Jan 31, 2023 · 0 comments · Fixed by #362
Assignees
@jphickey
Labels
draco-rc4 enhancement
Milestone
Draco

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Some deployment scenarios for CF may require some extra platform-specific trailing data to be appended to the end of the PDUs, for example a custom CRC or error check/correction code.

Describe the solution you'd like
To facilitate this, CF should offer an option to add extra padding bytes to the end of the PDU so that the platform may fill these bytes with the desired trailing data.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jan 31, 2023
jphickey added a commit to jphickey/CF that referenced this issue Jan 31, 2023
@jphickey
Fix nasa#361, add option for trailer bytes in CFDP PDUs
494e403 
Adds an option to insert platform-specific padding at the end of CFDP
PDU encapsulation.  The padding area may be utilized by the deployment
to add arbitrary verification information to the PDU.
jphickey added a commit to jphickey/CF that referenced this issue Jan 31, 2023
@jphickey
Fix nasa#361, add option for trailer bytes in CFDP PDUs
657b03d 
Adds an option to insert platform-specific padding at the end of CFDP
PDU encapsulation.  The padding area may be utilized by the deployment
to add arbitrary verification information to the PDU.
jphickey added a commit to jphickey/CF that referenced this issue Jan 31, 2023
@jphickey
Fix nasa#361, add option for trailer bytes in CFDP PDUs
d0efdf0 
Adds an option to insert platform-specific padding at the end of CFDP
PDU encapsulation.  The padding area may be utilized by the deployment
to add arbitrary verification information to the PDU.
@jphickey jphickey mentioned this issue Jan 31, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Feb 1, 2023
@dzbaker
Merge pull request #362 from jphickey/fix-361-trailer-padding
19c18b9 
Fix #361, add option for trailer bytes in CFDP PDUs
@dmknutsen dmknutsen added this to the Draco milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
draco-rc4 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #361, add option for trailer bytes in CFDP PDUs jphickey/CF
3 participants
@dzbaker @jphickey @dmknutsen