Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins do not currently restrict same names either within type or between types #163

Open
asgibson opened this issue Nov 8, 2024 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@asgibson
Copy link
Contributor

asgibson commented Nov 8, 2024

Currently using the same name plugin within a plugin dict silently overwrites the previous definition. This would result in user frustration as it may be unclear what is wrong in their config file.

Currently using the same name plugin between types is allowed and does create two distinct objects (all 4 types are held in their own list). Also, the high_level_data does separate results by type, {'vehicle_rep': {'same_name':{}}, 'learning_systems': {'same_name':{}}, 'planning_systems': {'same_name':{}}, 'complex_systems':{'same_name':{}}}. However this could be confusing using outputs or referring to plugins by name, especially if a plugin ignores the keys and directly accesses values of the high_level_data.

Should it stay the same (not recommended), accept but warn users, or deny one or both of these operations?

@asgibson asgibson added help wanted Extra attention is needed question Further information is requested labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant