-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: Kraken2/Bracken on Unaligned Sequences for Contamination Detection #1351
Conversation
Massive conda modules update
Slight fixes for rnaseq preprocessing
Prerelease 3.15.1 version bumps
Master merge
Co-authored-by: Jonathan Manning <pininforthefjords@gmail.com>
nf-core pipelines bump-version 3.16.0dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Let's get this merged!), provided that you rebase before to the latest dev (or merge in those changes).
@maxulysse ideally should help with the subway map, though.
The subway map has been updated, though not the animated one. I had an issue with the merge request, so I unintentionally now have all the 3.15 commits showing up here. Unsure if we can do something about that here or if I should open a new, clean PR from my fork. I'm guessing opening a new, clean PR may be easiest. Otherwise, the linting failure seems to be due to the HISAT2 patch that allows for using contaminant screening to have the unaligned reads saved for further processing downstream. |
Congrats @egreenberg7 :) Truly awesome work! |
New PR will be opened to show more clear version changes due to the merge issues. I'll also copy some of the comments over for the record |
No need to copy over the comments, just mention this PR, that'll be enough |
Closes #271. This contribution adds Kraken2/Bracken as an optional quality control step to the rnaseq pipeline for the HISAT2 and STAR/Salmon aligners. Contamination is a widely reported issue in rna-sequencing data, and the use of metagenomics tools can be used to address this. Kraken2 is particularly strong at detecting low levels of pathogens, which makes it appropriate for this task. This PR adds the option of providing a Kraken2 database to perform taxonomic classifications on unaligned reads.
Note: If the --bracken-precision parameter is set to something other than 'S', the current MultiQC version does not work properly. In future versions of MultiQC, this will not be an issue (see this MultiQC bug fix).
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated. [I do not think this is needed for my PR.]docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).