Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play sound feedback when listening the events #7

Closed
niw opened this issue Jan 19, 2018 · 9 comments
Closed

Play sound feedback when listening the events #7

niw opened this issue Jan 19, 2018 · 9 comments
Assignees

Comments

@niw
Copy link
Owner

niw commented Jan 19, 2018

In the comment of #4, @chrisballinger brings up that it would be better to have a sound feedback instead of haptic feedback. This is an issue to memo this request.

@munsuri
Copy link

munsuri commented Jan 23, 2018

I'm down for that one too. I was planning to add it myself after the one key event.

@munsuri
Copy link

munsuri commented Jan 24, 2018

Actually, it was quicker than expected to implement audio feedback with AVAudioPlayer. I've used a shorter version (silence from start and end removed) of this sound. Now, the sound intensity can be controlled (or not) as well through that API.

@niw niw self-assigned this Jan 29, 2018
@muescha
Copy link

muescha commented Jan 29, 2018

@munsuri you should create a pull request with your modification

@niw niw closed this as completed Jan 29, 2018
@niw niw reopened this Jan 29, 2018
@niw
Copy link
Owner Author

niw commented Jan 29, 2018

Sorry, I accidentally hit “Close issue” button, please ignore the last activities.

@chrisballinger
Copy link

If anyone wants to play around with the old Mac OS 9 Platinum sounds for nostalgia purposes, I extracted them from the resource fork of the original sound set I found somewhere online. I'm a fan of 00548 "wopn".aiff, but there are a number of other good ones.

Mac OS 9 Platinum Sounds.zip

@niw
Copy link
Owner Author

niw commented Jan 30, 2018

Okay, so I made a change to support sound effect 4cbef9f and some other features.
Since there are some concerns so didn’t merge this into master yet, once it’s solved I’ll post a new release.

@chrisballinger if you want to use that sound, you can add that sound as a resource to the project (Simply drag and drop to Resources group,) and modify line 45 of 4cbef9f to [[HTKSystemSound alloc] initWithPath:[[NSBundle mainBundle] pathForResource:@"wopn" ofType:@"aiff"].
Due to license, I think it’s not good idea to have that sound file in the repository, but, you can at least try it now. 😉

@chrisballinger
Copy link

Yeah I agree about the licensing, probably not a good idea to ship those by default. Perhaps a few royalty free default sounds could be included, selectable via Sounds sub-menu. Then you could drop external sound files into ~/Library/Application Support/HapticKey/Sounds/ and enumerate them within the sub-menu along with the bundled sounds. I'd submit a PR for that once things settle down a bit.

@niw
Copy link
Owner Author

niw commented Jan 30, 2018

@chrisballinger That approach sounds good!

@niw
Copy link
Owner Author

niw commented Jan 30, 2018

As I described in the comments, added ”Sound Effect” feedback option in a commit 4cbef9f.
Also released HapticKey 0.4.1.

@niw niw closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants