-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play sound feedback when listening the events #7
Comments
I'm down for that one too. I was planning to add it myself after the one key event. |
Actually, it was quicker than expected to implement audio feedback with AVAudioPlayer. I've used a shorter version (silence from start and end removed) of this sound. Now, the sound intensity can be controlled (or not) as well through that API. |
@munsuri you should create a pull request with your modification |
Sorry, I accidentally hit “Close issue” button, please ignore the last activities. |
If anyone wants to play around with the old Mac OS 9 Platinum sounds for nostalgia purposes, I extracted them from the resource fork of the original sound set I found somewhere online. I'm a fan of |
Okay, so I made a change to support sound effect 4cbef9f and some other features. @chrisballinger if you want to use that sound, you can add that sound as a resource to the project (Simply drag and drop to Resources group,) and modify line 45 of 4cbef9f to |
Yeah I agree about the licensing, probably not a good idea to ship those by default. Perhaps a few royalty free default sounds could be included, selectable via Sounds sub-menu. Then you could drop external sound files into |
@chrisballinger That approach sounds good! |
As I described in the comments, added ”Sound Effect” feedback option in a commit 4cbef9f. |
In the comment of #4, @chrisballinger brings up that it would be better to have a sound feedback instead of haptic feedback. This is an issue to memo this request.
The text was updated successfully, but these errors were encountered: