fix: properly show npm view ./directory (#4576)

npm · Mar 17, 2022 · 84d1921 · 84d1921
1 parent 2361a68
commit 84d1921
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/lib/commands/view.js b/lib/commands/view.js
@@ -103,6 +103,7 @@ class View extends BaseCommand {
       // put the version back if it existed
       pkg = `${manifest.name}${pkg.slice(1)}`
     }
+
     let wholePackument = false
     if (!args.length) {
       args = ['']
@@ -196,7 +197,7 @@ class View extends BaseCommand {
     // get the data about this package
     let version = this.npm.config.get('tag')
     // rawSpec is the git url if this is from git
-    if (spec.type !== 'git' && spec.rawSpec) {
+    if (spec.type !== 'git' && spec.type !== 'directory' && spec.rawSpec) {
       version = spec.rawSpec
     }
 
@@ -205,7 +206,6 @@ class View extends BaseCommand {
     if (pckmnt['dist-tags'] && pckmnt['dist-tags'][version]) {
       version = pckmnt['dist-tags'][version]
     }
-
     if (pckmnt.time && pckmnt.time.unpublished) {
       const u = pckmnt.time.unpublished
       const er = new Error(`Unpublished on ${u.time}`)

diff --git a/tap-snapshots/test/lib/commands/view.js.test.cjs b/tap-snapshots/test/lib/commands/view.js.test.cjs
@@ -68,6 +68,23 @@ yellow@1.0.1 'claudia'
 yellow@1.0.2 'claudia'
 `
 
+exports[`test/lib/commands/view.js TAP should log info of package in current working dir directory > must match snapshot 1`] = `
+
+
+[4m[1m[32mblue[39m@[32m1.0.0[39m[22m[24m | [1m[31mProprietary[39m[22m | deps: [32mnone[39m | versions: [33m2[39m
+
+dist
+.tarball:[36mhttp://hm.blue.com/1.0.0.tgz[39m
+.shasum:[33m123[39m
+.integrity:[33m---[39m
+.unpackedSize:[33m1 B[39m
+
+dist-tags:
+[1m[32mlatest[39m[22m: 1.0.0
+
+published {TIME} ago[39m
+`
+
 exports[`test/lib/commands/view.js TAP should log info of package in current working dir non-specific version > must match snapshot 1`] = `
 
 

diff --git a/test/lib/commands/view.js b/test/lib/commands/view.js
@@ -265,6 +265,9 @@ const packument = (nv, opts) => {
   if (nv.type === 'git') {
     return mocks[nv.hosted.project]
   }
+  if (nv.raw === './blue') {
+    return mocks.blue
+  }
   return mocks[nv.name]
 }
 
@@ -390,6 +393,11 @@ t.test('should log info of package in current working dir', async t => {
     await view.exec(['.'])
     t.matchSnapshot(logs)
   })
+
+  t.test('directory', async t => {
+    await view.exec(['./blue'])
+    t.matchSnapshot(logs)
+  })
 })
 
 t.test('should log info by field name', async t => {